Support custom request and notification handlers #44
+137
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to specify custom handler functions instead of the
receive-*
multi-methods.The main reason for that is to enable middleware, e.g. to log/time/trace requests, execute them on different threads, etc. Using the
:request-handler
and:notification-handler
options, one could create Ring-style middleware:Avoiding global state in the multi-methods also allows having multiple LSP implementations on the classpath. Not a common use case, but we found ourselves in the situation where we had both
clojure-lsp
(to use the linter) and our custom LSP on the dev classpath.Some tests could now be simplified, using
:request-handler
instead ofwith-redefs
.